[PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

Andy Shevchenko andy.shevchenko at gmail.com
Tue Dec 5 05:11:55 AEDT 2023

On Mon, Dec 4, 2023 at 8:07 PM George Stark <gnstark at salutedevices.com> wrote:
> Using of devm API leads to certain order of releasing resources.
> So all dependent resources which are not devm-wrapped should be deleted
> with respect to devm-release order. Mutex is one of such objects that
> often is bound to other resources and has no own devm wrapping.
> Since mutex_destroy() actually does nothing in non-debug builds
> frequently calling mutex_destroy() is just ignored which is safe for now
> but wrong formally and can lead to a problem if mutex_destroy() is
> extended so introduce devm_mutex_init().


Do you need to include mutex.h?


> +/**
> + * devm_mutex_init - Resource-managed mutex initialization
> + * @dev:       Device which lifetime work is bound to
> + * @lock:      Pointer to a mutex
> + *
> + * Initialize mutex which is automatically destroyed when driver is detached.

the driver

Have you run scripts/kernel-doc -v -Wall -none ... against this file?
I'm pretty sure it will complain.

> + */

With Best Regards,
Andy Shevchenko

More information about the Linuxppc-dev mailing list