[PATCH] macintosh/ams: linux/platform_device.h is needed
Michael Ellerman
patch-notifications at ellerman.id.au
Thu Aug 31 22:09:47 AEST 2023
On Tue, 29 Aug 2023 15:58:37 -0700, Randy Dunlap wrote:
> ams.h uses struct platform_device, so the header should be used
> to prevent build errors:
>
> drivers/macintosh/ams/ams-input.c: In function 'ams_input_enable':
> drivers/macintosh/ams/ams-input.c:68:45: error: invalid use of undefined type 'struct platform_device'
> 68 | input->dev.parent = &ams_info.of_dev->dev;
> drivers/macintosh/ams/ams-input.c: In function 'ams_input_init':
> drivers/macintosh/ams/ams-input.c:146:51: error: invalid use of undefined type 'struct platform_device'
> 146 | return device_create_file(&ams_info.of_dev->dev, &dev_attr_joystick);
> drivers/macintosh/ams/ams-input.c: In function 'ams_input_exit':
> drivers/macintosh/ams/ams-input.c:151:44: error: invalid use of undefined type 'struct platform_device'
> 151 | device_remove_file(&ams_info.of_dev->dev, &dev_attr_joystick);
> drivers/macintosh/ams/ams-input.c: In function 'ams_input_init':
> drivers/macintosh/ams/ams-input.c:147:1: error: control reaches end of non-void function [-Werror=return-type]
> 147 | }
>
> [...]
Applied to powerpc/next.
[1/1] macintosh/ams: linux/platform_device.h is needed
https://git.kernel.org/powerpc/c/85a616416e9e01db0bfa92f26457e92642e2236b
cheers
More information about the Linuxppc-dev
mailing list