[PATCH] Revert "ASoC: fsl: remove unnecessary dai_link->platform"

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Thu Apr 20 10:11:54 AEST 2023

Hi Shengjiu
Cc Mark

Thank you for the patch

> This reverts commit 33683cbf49b5412061cb1e4c876063fdef86def4.
> dai_link->platform is needed. The platform component is
> "snd_dmaengine_pcm", which is registered from cpu driver,
> If dai_link->platform is not assigned, then platform
> component will not be probed, then there will be issue:
> aplay: main:831: audio open error: Invalid argument
> Signed-off-by: Shengjiu Wang <shengjiu.wang at nxp.com>
> ---

And sorry to my noise patch. I understood the issue.

Can I ask 2 things ?

My original patch removed 3 platforms.
Then, I understood that 2 of them are used as
soc-generic-dmaengine-pcm (= 1st, 3rd platform).

I think we want to have comment here that
why dummy component is needed. Can you agree ?

I wonder how about 2nd platform ? Is it same ?
I'm asking because it doesn't have of_node which other 2 platforms have.

Thank you for your help !!

Best regards
Kuninori Morimoto

More information about the Linuxppc-dev mailing list