[PATCH v3 6/6] PCI/AER: Unmask RCEC internal errors to enable RCH downstream port error handling

Dan Williams dan.j.williams at intel.com
Tue Apr 18 12:37:45 AEST 2023

Terry Bowman wrote:
> From: Robert Richter <rrichter at amd.com>
> RCEC AER corrected and uncorrectable internal errors (CIE/UIE) are
> disabled by default. [1][2] Enable them to receive CXL downstream port
> errors of a Restricted CXL Host (RCH).
> [1] CXL 3.0 Spec, - RCH Downstream Port Detected Errors
> [2] PCIe Base Spec 6.0, Uncorrectable Error Mask Register,
> Correctable Error Mask Register

My comment on patch5 to make CXL link details a first class property of a
'struct pci_dev':


...also applies here.

Other than that nothing more from me on this one beyond what Bjorn and
Jonathan have said. I do agree with Robert about being cautious about
only enabling this for CXL devices for now and not all internal errors
for all AER capable devices globally. The rationale being that CXL
devices are a new link on top of PCIe and abuse/reuse internal errors
when they are conceptually functionally equivalent to PCIe link errors.

More information about the Linuxppc-dev mailing list