[PATCH 3/4] cpuidle: pseries: Mark ->enter() functions as __cpuidle

Sachin Sant sachinp at linux.ibm.com
Tue Apr 11 19:02:06 AEST 2023



> On 06-Apr-2023, at 8:15 PM, Michael Ellerman <mpe at ellerman.id.au> wrote:
> 
> Code in the idle path is not allowed to be instrumented because RCU is
> disabled, see commit 0e985e9d2286 ("cpuidle: Add comments about
> noinstr/__cpuidle usage").
> 
> Mark the cpuidle ->enter() callbacks as __cpuidle and use the
> raw_local_irq_*() routines to ensure that is the case.
> 
> Reported-by: Sachin Sant <sachinp at linux.ibm.com>
> Suggested-by: Peter Zijlstra <peterz at infradead.org>
> Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>
> ---

Thanks for the patch. With this patch (and others from the series)
applied, I no longer observe the reported kernel warning while running
ftrace selftests.

For this and other patches in the series

Tested-by: Sachin Sant <sachinp at linux.ibm.com>

- Sachin


More information about the Linuxppc-dev mailing list