[PATCH v2 09/19] arch/mips: Implement <asm/fb.h> with generic helpers

Arnd Bergmann arnd at arndb.de
Fri Apr 7 00:51:14 AEST 2023

On Thu, Apr 6, 2023, at 16:30, Thomas Zimmermann wrote:
> Replace the architecture's fb_is_primary_device() with the generic
> one from <asm-generic/fb.h>. No functional changes.
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> Cc: Thomas Bogendoerfer <tsbogend at alpha.franken.de>

I think you should at least mention that the existing
fb_pgprotect() function is probably incorrect and should
be replaced with the generic version.

For reference, the fb_pgprotect function using pgprot_uncached()
was introduced in 2.6.22 along with all the other ones, but
the pgprot_writecombine function was only added in commit
4b050ba7a66c ("MIPS: pgtable.h: Implement the pgprot_writecombine
function for MIPS") for 3.18.


More information about the Linuxppc-dev mailing list