[PATCH v2 10/10] drm/ofdrm: Support color management

Thomas Zimmermann tzimmermann at suse.de
Thu Sep 22 16:42:23 AEST 2022


Hi

Am 21.09.22 um 18:48 schrieb Geert Uytterhoeven:
> Hi Thomas,
> 
> On Wed, Sep 21, 2022 at 2:55 PM Thomas Zimmermann <tzimmermann at suse.de> wrote:
>> Am 05.08.22 um 02:19 schrieb Benjamin Herrenschmidt:
>>> On Wed, 2022-07-20 at 16:27 +0200, Thomas Zimmermann wrote:
>>>> +#if !defined(CONFIG_PPC)
>>>> +static inline void out_8(void __iomem *addr, int val)
>>>> +{ }
>>>> +static inline void out_le32(void __iomem *addr, int val)
>>>> +{ }
>>>> +static inline unsigned int in_le32(const void __iomem *addr)
>>>> +{
>>>> +       return 0;
>>>> +}
>>>> +#endif
>>>
>>> These guys could just be replaced with readb/writel/readl respectively
>>> (beware of the argument swap).
>>
>> I only added them for COMPILE_TEST. There appears to be no portable
>> interface that implements out_le32() and in_le32()?
> 
> iowrite32() and ioread32()?

Do they always use little endian, as these *_le32 helpers do? I though 
they use host byte order.

Best regards
Thomas

> 
> Gr{oetje,eeting}s,
> 
>                          Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20220922/be303e11/attachment.sig>


More information about the Linuxppc-dev mailing list