[PATCH] macintosh/ams: Adapt declaration of ams_i2c_remove() to earlier change

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Fri Sep 16 19:08:02 AEST 2022


Commit ed5c2f5fd10d ("i2c: Make remove callback return void") changed
the prototype of ams_i2c_remove() but failed to adapt the declaration.
Catch up and fix the declaration accordingly.

Fixes: ed5c2f5fd10d ("i2c: Make remove callback return void")
Reported-by: kernel test robot <lkp at intel.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
---
Hello,

the kernel test robot found a regression. I checked the kernel tree and
(assuming I did it correctly) there are no other instances where I
missed to adapt a declaration.

I don't know how to proceed with this fix. Squashing into the broken
commit is out of the game as the commit is on a stable branch that is
already merged in a few trees. Maybe let it go in via the i2c tree?

Best regards
Uwe

 drivers/macintosh/ams/ams-i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/macintosh/ams/ams-i2c.c b/drivers/macintosh/ams/ams-i2c.c
index 362fc56b69dc..3ded340699fb 100644
--- a/drivers/macintosh/ams/ams-i2c.c
+++ b/drivers/macintosh/ams/ams-i2c.c
@@ -58,7 +58,7 @@ enum ams_i2c_cmd {
 
 static int ams_i2c_probe(struct i2c_client *client,
 			 const struct i2c_device_id *id);
-static int ams_i2c_remove(struct i2c_client *client);
+static void ams_i2c_remove(struct i2c_client *client);
 
 static const struct i2c_device_id ams_id[] = {
 	{ "MAC,accelerometer_1", 0 },
-- 
2.37.2



More information about the Linuxppc-dev mailing list