[PATCH v2 0/2] Remove unused macros from asm-offset

Athira Rajeev atrajeev at linux.vnet.ibm.com
Mon Oct 17 16:56:25 AEDT 2022



> On 16-Sep-2022, at 4:27 PM, Disha Goel <disgoel at linux.vnet.ibm.com> wrote:
> 
> The kvm code was refactored to convert some of kvm assembly routines to C.
> This includes commits which moved code path for the kvm guest entry/exit
> for p7/8 from aseembly to C. As part of the code changes, usage of some of
> the macros were removed. But definitions still exist in the assembly files.
> Commits are listed below:
> 
> Commit 2e1ae9cd56f8 ("KVM: PPC: Book3S HV: Implement radix prefetch workaround by disabling MMU")
> Commit 9769a7fd79b6 ("KVM: PPC: Book3S HV: Remove radix guest support from P7/8 path")
> Commit fae5c9f3664b ("KVM: PPC: Book3S HV: remove ISA v3.0 and v3.1 support from P7/8 path")
> Commit 57dc0eed73ca ("KVM: PPC: Book3S HV P9: Implement PMU save/restore in C")
> 
> Many of the asm-offset macro definitions were missed to remove. This patchset
> fixes by removing the unused macro definitions.
> 

For the patchset,

Reviewed-by: Athira Rajeev <atrajeev at linux.vnet.ibm.com>

Thanks
Athira
> Patch1 removes a set of unused kvm vcpu and hstate macros from the
> asm-offset.c
> 
> Patch2 removes unused host_mmcr references for MMCR3/SIER2/SIER3
> 
> Changelog:
> v1 -> v2:
> Merge all the macro removal part from asm-offset.c file into a single patch
> as suggested by Christophe Leroy.
> 
> Link to patchset v1:
> http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220913074025.132160-2-disgoel@linux.vnet.ibm.com/
> 
> Link to the script used to get unused macro:
> https://github.com/maddy-kerneldev/scripts/blob/master/check_asm-offset.sh
> 
> Link to linux-ci job result:
> https://github.com/disgoel/linux-ci/actions?query=branch%3Akvmmacro.v2
> 
> Disha Goel (1):
>  powerpc/kvm: Remove unused macros from asm-offset
> 
> Kajol Jain (1):
>  powerpc/kvm: Remove unused references for MMCR3/SIER2/SIER3 registers
> 
> arch/powerpc/include/asm/kvm_book3s_asm.h |  2 +-
> arch/powerpc/kernel/asm-offsets.c         | 25 -----------------------
> 2 files changed, 1 insertion(+), 26 deletions(-)
> 
> -- 
> 2.31.1
> 



More information about the Linuxppc-dev mailing list