[PATCH v6 08/16] objtool: Fix SEGFAULT

Sathvika Vasireddy sv at linux.ibm.com
Tue Nov 15 04:57:46 AEDT 2022


From: Christophe Leroy <christophe.leroy at csgroup.eu>

find_insn() will return NULL in case of failure. Check insn in order
to avoid a kernel Oops for NULL pointer dereference.

Tested-by: Naveen N. Rao <naveen.n.rao at linux.vnet.ibm.com>
Reviewed-by: Naveen N. Rao <naveen.n.rao at linux.vnet.ibm.com>
Acked-by: Josh Poimboeuf <jpoimboe at kernel.org>
Acked-by: Peter Zijlstra (Intel) <peterz at infradead.org>
Signed-off-by: Christophe Leroy <christophe.leroy at csgroup.eu>
---
 tools/objtool/check.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 43ec14c29a60..8427af808221 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -207,7 +207,7 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func,
 		return false;
 
 	insn = find_insn(file, func->sec, func->offset);
-	if (!insn->func)
+	if (!insn || !insn->func)
 		return false;
 
 	func_for_each_insn(file, func, insn) {
-- 
2.31.1



More information about the Linuxppc-dev mailing list