[PATCH v4] i2c/pasemi: PASemi I2C controller IRQ enablement
Wolfram Sang
wsa at kernel.org
Sun Nov 13 07:33:28 AEDT 2022
On Sat, Nov 05, 2022 at 07:56:49AM -0400, Arminder Singh wrote:
> This patch adds IRQ support to the PASemi I2C controller driver to
> increase the performace of I2C transactions on platforms with PASemi I2C
> controllers. While primarily intended for Apple silicon platforms, this
> patch should also help in enabling IRQ support for older PASemi hardware
> as well should the need arise.
>
> This version of the patch has been tested on an M1 Ultra Mac Studio,
> as well as an M1 MacBook Pro, and userspace launches successfully
> while using the IRQ path for I2C transactions.
>
> Signed-off-by: Arminder Singh <arminders208 at outlook.com>
Applied to for-next, thanks! One thing, though:
> + while (!(status & SMSTA_XEN) && timeout--) {
> + msleep(1);
Checkpatch complained about this one:
WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Not your issue because you were just moving this code around. But this
might be a candidate for future improvements, thiugh.
> + status = reg_read(smbus, REG_SMSTA);
> + }
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20221112/c1dae18c/attachment.sig>
More information about the Linuxppc-dev
mailing list