[PATCH] powerpc/8xx: Fix warning in hw_breakpoint_handler()

Christophe Leroy christophe.leroy at csgroup.eu
Thu Nov 3 18:47:18 AEDT 2022



Le 24/10/2022 à 06:13, Russell Currey a écrit :
> In hw_breakpoint_handler(), ea is set by wp_get_instr_detail() except
> for 8xx, leading the variable to be passed uninitialised to
> wp_check_constraints().  This is safe as wp_check_constraints() returns
> early without using ea, so just set it to make the compiler happy.
> 
> Signed-off-by: Russell Currey <ruscur at russell.cc>

Reviewed-by: Christophe Leroy <christophe.leroy at csgroup.eu>

> ---
>   arch/powerpc/kernel/hw_breakpoint.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/kernel/hw_breakpoint.c b/arch/powerpc/kernel/hw_breakpoint.c
> index 8db1a15d7acb..e1b4e70c8fd0 100644
> --- a/arch/powerpc/kernel/hw_breakpoint.c
> +++ b/arch/powerpc/kernel/hw_breakpoint.c
> @@ -646,7 +646,7 @@ int hw_breakpoint_handler(struct die_args *args)
>   	ppc_inst_t instr = ppc_inst(0);
>   	int type = 0;
>   	int size = 0;
> -	unsigned long ea;
> +	unsigned long ea = 0;
>   
>   	/* Disable breakpoints during exception handling */
>   	hw_breakpoint_disable();


More information about the Linuxppc-dev mailing list