[PATCH 22/30] panic: Introduce the panic post-reboot notifier list
Guilherme G. Piccoli
gpiccoli at igalia.com
Tue May 17 02:08:15 AEST 2022
On 16/05/2022 11:45, Petr Mladek wrote:
> [...]
>
> The patch looks good to me. I would just suggest two changes.
>
> 1. I would rename the list to "panic_loop_list" instead of
> "panic_post_reboot_list".
>
> It will be more clear that it includes things that are
> needed before panic() enters the infinite loop.
>
>
> 2. I would move all the notifiers that enable blinking here.
>
> The blinking should be done only during the infinite
> loop when there is nothing else to do. If we enable
> earlier then it might disturb/break more important
> functionality (dumping information, reboot).
>
Perfect, I agree with you. I'll change both points in V2 =)
More information about the Linuxppc-dev
mailing list