[PATCH v6 13/29] iommu/amd: Compose MSI messages for NMI irqs in non-IR format

Ricardo Neri ricardo.neri-calderon at linux.intel.com
Sat May 14 05:03:19 AEST 2022


On Fri, May 06, 2022 at 11:31:56PM +0200, Thomas Gleixner wrote:
> On Thu, May 05 2022 at 16:59, Ricardo Neri wrote:
> > +	 *
> > +	 * Also, NMIs do not have an associated vector. No need for cleanup.
> 
> They have a vector and what the heck is this cleanup comment for here?
> There is nothing cleanup alike anywhere near.
> 
> Adding confusing comments is worse than adding no comments at all.

I will remove the comment regarding cleanup. I will clarify that NMI has a
fixed vector.

Thanks and BR,
Ricardo


More information about the Linuxppc-dev mailing list