[PATCH] POWERPC: idle: fix return value of __setup handler

Michael Ellerman mpe at ellerman.id.au
Tue May 3 10:55:15 AEST 2022


Randy Dunlap <rdunlap at infradead.org> writes:
> On 5/2/22 06:19, Michael Ellerman wrote:
>> Randy Dunlap <rdunlap at infradead.org> writes:
>>> __setup() handlers should return 1 to obsolete_checksetup() in
>>> init/main.c to indicate that the boot option has been handled.
>>> A return of 0 causes the boot option/value to be listed as an Unknown
>>> kernel parameter and added to init's (limited) argument or environment
>>> strings. Also, error return codes don't mean anything to
>>> obsolete_checksetup() -- only non-zero (usually 1) or zero.
>>> So return 1 from powersave_off().
>>>
>>> Fixes: 302eca184fb8 ("[POWERPC] cell: use ppc_md->power_save instead of cbe_idle_loop")
>>> Signed-off-by: Randy Dunlap <rdunlap at infradead.org>
>>> From: Igor Zhbanov <i.zhbanov at omprussia.ru>
>> 
>> What happened here? Is the patch actually from Igor? If so he should be
>> the author, and it should include his SoB shouldn't it?
>
> I don't know what happened. I did the patches.
> I'll resend them.

Thanks.

cheers


More information about the Linuxppc-dev mailing list