[PATCH] POWERPC: idle: fix return value of __setup handler

[Christophe Leroy]

Le 02/05/2022 à 17:50, Randy Dunlap a écrit :
> 
> 
> On 5/2/22 06:19, Michael Ellerman wrote:
>> Randy Dunlap <rdunlap at infradead.org> writes:
>>> __setup() handlers should return 1 to obsolete_checksetup() in
>>> init/main.c to indicate that the boot option has been handled.
>>> A return of 0 causes the boot option/value to be listed as an Unknown
>>> kernel parameter and added to init's (limited) argument or environment
>>> strings. Also, error return codes don't mean anything to
>>> obsolete_checksetup() -- only non-zero (usually 1) or zero.
>>> So return 1 from powersave_off().
>>>
>>> Fixes: 302eca184fb8 ("[POWERPC] cell: use ppc_md->power_save instead of cbe_idle_loop")
>>> Signed-off-by: Randy Dunlap <rdunlap at infradead.org>
>>> From: Igor Zhbanov <i.zhbanov at omprussia.ru>
>>
>> What happened here? Is the patch actually from Igor? If so he should be
>> the author, and it should include his SoB shouldn't it?
> 
> I don't know what happened. I did the patches.
> I'll resend them.
> 

Some erroneous copy/paste from 
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220308024228.20477-1-rdunlap@infradead.org/ 
?


> Thanks.
> 
>> Same comment for "[PATCH] powerpc/4xx: cpm: fix return value of __setup handler".
>>
>> cheers
>>
>>> Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3 at omprussia.ru
>>> Cc: Arnd Bergmann <arnd at arndb.de>
>>> Cc: Paul Mackerras <paulus at samba.org>
>>> Cc: Michael Ellerman <mpe at ellerman.id.au>
>>> Cc: Benjamin Herrenschmidt <benh at kernel.crashing.org>
>>> ---
>>>   arch/powerpc/kernel/idle.c |    2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> --- linux-next-20220310.orig/arch/powerpc/kernel/idle.c
>>> +++ linux-next-20220310/arch/powerpc/kernel/idle.c
>>> @@ -37,7 +37,7 @@ static int __init powersave_off(char *ar
>>>   {
>>>   	ppc_md.power_save = NULL;
>>>   	cpuidle_disable = IDLE_POWERSAVE_OFF;
>>> -	return 0;
>>> +	return 1;
>>>   }
>>>   __setup("powersave=off", powersave_off);
>>>   
>