[PATCH] POWERPC: idle: fix return value of __setup handler

[Michael Ellerman]

Randy Dunlap <rdunlap at infradead.org> writes:
> __setup() handlers should return 1 to obsolete_checksetup() in
> init/main.c to indicate that the boot option has been handled.
> A return of 0 causes the boot option/value to be listed as an Unknown
> kernel parameter and added to init's (limited) argument or environment
> strings. Also, error return codes don't mean anything to
> obsolete_checksetup() -- only non-zero (usually 1) or zero.
> So return 1 from powersave_off().
>
> Fixes: 302eca184fb8 ("[POWERPC] cell: use ppc_md->power_save instead of cbe_idle_loop")
> Signed-off-by: Randy Dunlap <rdunlap at infradead.org>
> From: Igor Zhbanov <i.zhbanov at omprussia.ru>

What happened here? Is the patch actually from Igor? If so he should be
the author, and it should include his SoB shouldn't it?

Same comment for "[PATCH] powerpc/4xx: cpm: fix return value of __setup handler".

cheers

> Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3 at omprussia.ru
> Cc: Arnd Bergmann <arnd at arndb.de>
> Cc: Paul Mackerras <paulus at samba.org>
> Cc: Michael Ellerman <mpe at ellerman.id.au>
> Cc: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> ---
>  arch/powerpc/kernel/idle.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20220310.orig/arch/powerpc/kernel/idle.c
> +++ linux-next-20220310/arch/powerpc/kernel/idle.c
> @@ -37,7 +37,7 @@ static int __init powersave_off(char *ar
>  {
>  	ppc_md.power_save = NULL;
>  	cpuidle_disable = IDLE_POWERSAVE_OFF;
> -	return 0;
> +	return 1;
>  }
>  __setup("powersave=off", powersave_off);
>