[PATCH 00/22] Replace comments with C99 initializers
Daniel Thompson
daniel.thompson at linaro.org
Tue Mar 29 00:47:05 AEDT 2022
On Sun, Mar 27, 2022 at 02:46:00PM +0200, Benjamin Stürz wrote:
> This patch series replaces comments with C99's designated initializers
> in a few places. It also adds some enum initializers. This is my first
> time contributing to the Linux kernel, therefore I'm probably doing a
> lot of things the wrong way. I'm sorry for that.
Welcome!
> I've gotten a few emails so far stating that this patch series is
> unnecessary. Yes, in fact this patch series is not necessary by itself,
> but it could help me understand how the whole process works and maybe I
> could help somewhere, where help is actually needed.
Have you been told the series is unnecessary or too big?
Although all patches represent a variant of the same mechanical
transformation but they are mostly unrelated to each other and, if
accepted, they will be applied by many different people.
Taken as a whole presenting this to maintainers as a 22 patch set is too
big. I'd recommend starting with a smaller patch or patch series where
all the patches get picked up by the same maintainer.
> This patch itself is a no-op.
PATCH 0/XX is for the covering letter. You should generate a template for
it using the --cover-letter option of git format-patch. That way patch 0
will contain the diffstat for the whole series (which is often useful
to help understand what the series is for) and there is no need to
make no-op changes.
Daniel.
>
> Signed-off-by: Benjamin Stürz <benni at stuerz.xyz>
> ---
> .gitignore | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.gitignore b/.gitignore
> index 7afd412dadd2..706f667261eb 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -20,7 +20,7 @@
> *.dtb
> *.dtbo
> *.dtb.S
> -*.dwo
> +*.dwo
> *.elf
> *.gcno
> *.gz
> --
> 2.35.1
More information about the Linuxppc-dev
mailing list