[PATCH 1/2] powerpc: Reject probes on instructions that can't be single stepped

Michael Ellerman mpe at ellerman.id.au
Fri Mar 25 09:58:33 AEDT 2022


Murilo Opsfelder Araújo <mopsfelder at gmail.com> writes:
> On 3/23/22 08:51, Naveen N. Rao wrote:
...
>> +	case 31:
>> +		switch ((inst >> 1) & 0x3ff) {
>> +		case 4:		/* tw */
>> +			return false;
>> +		case 68:	/* td */
>> +			return false;
>> +		case 146:	/* mtmsr */
>> +			return false;
>> +		case 178:	/* mtmsrd */
>> +			return false;
>> +		}
>> +		break;
>> +	}
>> +	return true;
>> +}
>> +
>
> Can't OP_* definitions from ppc-opcode.h be used for all of these switch-case statements?

Yes please. And add any that are missing.

cheers


More information about the Linuxppc-dev mailing list