[PATCH v2 -next] powerpc/eeh: Remove unused inline functions

YueHaibing yuehaibing at huawei.com
Wed Mar 16 21:42:39 AEDT 2022


pseries_eeh_init_edev() is exclusively in eeh_pseries.c,
make it static and remove unused inline function.
pseries_eeh_init_edev_recursive() is only called from files build
wich CONFIG_HOTPLUG_PCI_RPA which depends on CONFIG_PSERIES and
CONFIG_EEH, so can remove the unused inline version.

Suggested-by: Christophe Leroy <christophe.leroy at csgroup.eu>
Signed-off-by: YueHaibing <yuehaibing at huawei.com>
---
v2: remove unused inline function instead of corret it.
---
 arch/powerpc/include/asm/eeh.h               | 4 ----
 arch/powerpc/platforms/pseries/eeh_pseries.c | 4 +++-
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h
index bd513fd49be9..8304727fba55 100644
--- a/arch/powerpc/include/asm/eeh.h
+++ b/arch/powerpc/include/asm/eeh.h
@@ -354,11 +354,7 @@ static inline int eeh_phb_pe_create(struct pci_controller *phb) { return 0; }
 #endif /* CONFIG_EEH */
 
 #if defined(CONFIG_PPC_PSERIES) && defined(CONFIG_EEH)
-void pseries_eeh_init_edev(struct pci_dn *pdn);
 void pseries_eeh_init_edev_recursive(struct pci_dn *pdn);
-#else
-static inline void pseries_eeh_add_device_early(struct pci_dn *pdn) { }
-static inline void pseries_eeh_add_device_tree_early(struct pci_dn *pdn) { }
 #endif
 
 #ifdef CONFIG_PPC64
diff --git a/arch/powerpc/platforms/pseries/eeh_pseries.c b/arch/powerpc/platforms/pseries/eeh_pseries.c
index 09fafcf2d3a0..f9af879c0222 100644
--- a/arch/powerpc/platforms/pseries/eeh_pseries.c
+++ b/arch/powerpc/platforms/pseries/eeh_pseries.c
@@ -43,6 +43,8 @@ static int ibm_get_config_addr_info;
 static int ibm_get_config_addr_info2;
 static int ibm_configure_pe;
 
+static void pseries_eeh_init_edev(struct pci_dn *pdn);
+
 static void pseries_pcibios_bus_add_device(struct pci_dev *pdev)
 {
 	struct pci_dn *pdn = pci_get_pdn(pdev);
@@ -359,7 +361,7 @@ static struct eeh_pe *pseries_eeh_pe_get_parent(struct eeh_dev *edev)
  * This function takes care of the initialisation and inserts the eeh_dev
  * into the correct eeh_pe. If no eeh_pe exists we'll allocate one.
  */
-void pseries_eeh_init_edev(struct pci_dn *pdn)
+static void pseries_eeh_init_edev(struct pci_dn *pdn)
 {
 	struct eeh_pe pe, *parent;
 	struct eeh_dev *edev;
-- 
2.17.1



More information about the Linuxppc-dev mailing list