[PATCH 6/6] i2c: Make remove callback return void

Jeremy Kerr jk at codeconstruct.com.au
Wed Jun 29 17:03:54 AEST 2022


Hi Uwe,

Looks good - just one minor change for the mctp-i2c driver, but only
worthwhile if you end up re-rolling this series for other reasons:

> -static int mctp_i2c_remove(struct i2c_client *client)
> +static void mctp_i2c_remove(struct i2c_client *client)
>  {
>         struct mctp_i2c_client *mcli = i2c_get_clientdata(client);
>         struct mctp_i2c_dev *midev = NULL, *tmp = NULL;
> @@ -1000,7 +1000,6 @@ static int mctp_i2c_remove(struct i2c_client *client)
>         mctp_i2c_free_client(mcli);
>         mutex_unlock(&driver_clients_lock);
>         /* Callers ignore return code */
> -       return 0;
>  }

The comment there no longer makes much sense, I'd suggest removing that
too. Either way:

Reviewed-by: Jeremy Kerr <jk at codeconstruct.com.au>

Cheers,


Jeremy


More information about the Linuxppc-dev mailing list