[PATCH 5.18 071/181] perf test topology: Use !strncmp(right platform) to fix guest PPC comparision check

Greg Kroah-Hartman gregkh at linuxfoundation.org
Mon Jun 27 21:20:44 AEST 2022


From: Athira Rajeev <atrajeev at linux.vnet.ibm.com>

[ Upstream commit b236371421df57b93fc49c4b9d0e53bd1aab2b2e ]

commit cfd7092c31aed728 ("perf test session topology: Fix test to skip
the test in guest environment") added check to skip the testcase if the
socket_id can't be fetched from topology info.

But the condition check uses strncmp which should be changed to !strncmp
and to correctly match platform.

Fix this condition check.

Fixes: cfd7092c31aed728 ("perf test session topology: Fix test to skip the test in guest environment")
Reported-by: Thomas Richter <tmricht at linux.ibm.com>
Signed-off-by: Athira Jajeev <atrajeev at linux.vnet.ibm.com>
Acked-by: Ian Rogers <irogers at google.com>
Cc: Athira Rajeev <atrajeev at linux.vnet.ibm.com>
Cc: Disha Goel <disgoel at linux.vnet.ibm.com>
Cc: Jiri Olsa <jolsa at kernel.org>
Cc: Kajol Jain <kjain at linux.ibm.com>
Cc: linuxppc-dev at lists.ozlabs.org
Cc: Madhavan Srinivasan <maddy at linux.ibm.com>
Cc: Michael Ellerman <mpe at ellerman.id.au>
Cc: Nageswara R Sastry <rnsastry at linux.ibm.com>
Link: https://lore.kernel.org/r/20220610135939.63361-1-atrajeev@linux.vnet.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme at redhat.com>
Signed-off-by: Sasha Levin <sashal at kernel.org>
---
 tools/perf/tests/topology.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/topology.c b/tools/perf/tests/topology.c
index d23a9e322ff5..0b4f61b6cc6b 100644
--- a/tools/perf/tests/topology.c
+++ b/tools/perf/tests/topology.c
@@ -115,7 +115,7 @@ static int check_cpu_topology(char *path, struct perf_cpu_map *map)
 	 * physical_package_id will be set to -1. Hence skip this
 	 * test if physical_package_id returns -1 for cpu from perf_cpu_map.
 	 */
-	if (strncmp(session->header.env.arch, "powerpc", 7)) {
+	if (!strncmp(session->header.env.arch, "ppc64le", 7)) {
 		if (cpu__get_socket_id(perf_cpu_map__cpu(map, 0)) == -1)
 			return TEST_SKIP;
 	}
-- 
2.35.1





More information about the Linuxppc-dev mailing list