[PATCH 3/3] powerpc/mm: Use VMALLOC_START to validate addr

Michael Ellerman mpe at ellerman.id.au
Fri Jun 24 12:45:24 AEST 2022


"Aneesh Kumar K.V" <aneesh.kumar at linux.ibm.com> writes:
> Instead of high_memory use VMALLOC_START to validate that the address is
> not in the vmalloc range.
>
> Cc: Kefeng Wang <wangkefeng.wang at huawei.com>
> Cc: Christophe Leroy <christophe.leroy at csgroup.eu>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.ibm.com>

Isn't this really the fix for ffa0b64e3be5 ("powerpc: Fix
virt_addr_valid() for 64-bit Book3E & 32-bit") ?

cheers

> diff --git a/arch/powerpc/include/asm/page.h b/arch/powerpc/include/asm/page.h
> index e5f75c70eda8..256cad69e42e 100644
> --- a/arch/powerpc/include/asm/page.h
> +++ b/arch/powerpc/include/asm/page.h
> @@ -134,7 +134,7 @@ static inline bool pfn_valid(unsigned long pfn)
>  
>  #define virt_addr_valid(vaddr)	({					\
>  	unsigned long _addr = (unsigned long)vaddr;			\
> -	_addr >= PAGE_OFFSET && _addr < (unsigned long)high_memory &&	\
> +	_addr >= PAGE_OFFSET && _addr < (unsigned long)VMALLOC_START &&	\
>  	pfn_valid(virt_to_pfn(_addr));					\
>  })
>  
> -- 
> 2.36.1


More information about the Linuxppc-dev mailing list