[PATCH v2 1/4] powerpc/pseries: hvcall.h: add H_WATCHDOG opcode, H_NOOP return code

Nathan Lynch nathanl at linux.ibm.com
Wed Jun 22 08:22:14 AEST 2022


Segher Boessenkool <segher at kernel.crashing.org> writes:

> Hi!
>
> On Tue, Jun 21, 2022 at 09:44:42AM -0500, Nathan Lynch wrote:
>> Not a problem to fix in your series, but I guess these should be
>> parenthesized i.e.
>> 
>> #define H_P7		(-60)
>> #define H_P8		(-61)
>> #define H_P9		(-62)
>> #define H_NOOP		(-63)
>
> Why?  It does not change the semantics of any correct code.  For what
> incorrect code will it make the diagnostics clearer?

Yeah never mind, I was confused.


More information about the Linuxppc-dev mailing list