[PATCH] powerpc: sysdev: Fix refcount leak bug in fsl_pci.c
Liang He
windhl at 126.com
Sat Jun 18 13:32:07 AEST 2022
In is_kdump(), we need a of_node_put() to dec the refcount which is
incremented by of_find_node_by_type().
Signed-off-by: Liang He <windhl at 126.com>
---
arch/powerpc/sysdev/fsl_pci.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c
index 1011cfea2e32..4c986c955951 100644
--- a/arch/powerpc/sysdev/fsl_pci.c
+++ b/arch/powerpc/sysdev/fsl_pci.c
@@ -180,6 +180,7 @@ static int setup_one_atmu(struct ccsr_pci __iomem *pci,
static bool is_kdump(void)
{
struct device_node *node;
+ bool ret;
node = of_find_node_by_type(NULL, "memory");
if (!node) {
@@ -187,7 +188,10 @@ static bool is_kdump(void)
return false;
}
- return of_property_read_bool(node, "linux,usable-memory");
+ ret = of_property_read_bool(node, "linux,usable-memory");
+ of_node_put(node);
+
+ return ret;
}
/* atmu setup for fsl pci/pcie controller */
--
2.25.1
More information about the Linuxppc-dev
mailing list