Re: 回复: [PATCH 2/2] uio:powerpc:mpc85xx: l2-cache-sram uio driver implementation

Christophe Leroy christophe.leroy at csgroup.eu
Wed Jun 15 16:04:01 AEST 2022



Le 14/06/2022 à 08:09, Wenhu Wang a écrit :
>>> +
>>> +static const struct vm_operations_struct uio_cache_sram_vm_ops = {
>>> +#ifdef CONFIG_HAVE_IOREMAP_PROT
>>
>> Same here.
>>
> 
> I tried to eliminate it in mainline
> See: [PATCH v2] mm: eliminate ifdef of HAVE_IOREMAP_PROT in .c files
> https://lkml.org/lkml/2022/6/10/695
> 
>>> +     .access = generic_access_phys,
>>> +#endif
>>> +};

Another solution is to do:


static const struct vm_operations_struct uio_cache_sram_vm_ops = {
	.access = IS_ENABLED(CONFIG_HAVE_IOREMAP_PROT) ? generic_access_phys : 
NULL,
};


Christophe


More information about the Linuxppc-dev mailing list