[PATCH] tools/perf/tests: Fix session topology test comparison check

[Ian Rogers]

On Fri, Jun 10, 2022 at 7:00 AM Athira Rajeev
<atrajeev at linux.vnet.ibm.com> wrote:
>
> commit cfd7092c31ae ("perf test session topology: Fix test to
> skip the test in guest environment") added check to skip the
> testcase if the socket_id can't be fetched from topology info.
> But the condition check uses strncmp which should be changed to
> !strncmp and to correctly match platform. Patch fixes this
> condition check.
>
> Fixes: cfd7092c31ae ("perf test session topology: Fix test to skip the test in guest environment")
> Reported-by: Thomas Richter <tmricht at linux.ibm.com>
> Signed-off-by: Athira Rajeev <atrajeev at linux.vnet.ibm.com>

Acked-by: Ian Rogers <irogers at google.com>

Thanks,
Ian

> ---
>  tools/perf/tests/topology.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/topology.c b/tools/perf/tests/topology.c
> index d23a9e322ff5..0b4f61b6cc6b 100644
> --- a/tools/perf/tests/topology.c
> +++ b/tools/perf/tests/topology.c
> @@ -115,7 +115,7 @@ static int check_cpu_topology(char *path, struct perf_cpu_map *map)
>          * physical_package_id will be set to -1. Hence skip this
>          * test if physical_package_id returns -1 for cpu from perf_cpu_map.
>          */
> -       if (strncmp(session->header.env.arch, "powerpc", 7)) {
> +       if (!strncmp(session->header.env.arch, "ppc64le", 7)) {
>                 if (cpu__get_socket_id(perf_cpu_map__cpu(map, 0)) == -1)
>                         return TEST_SKIP;
>         }
> --
> 2.35.1
>