Re: 回复: [PATCH 2/2] uio:powerpc:mpc85xx: l2-cache-sram uio driver implementation

Christophe Leroy christophe.leroy at csgroup.eu
Tue Jun 14 17:12:18 AEST 2022



Le 14/06/2022 à 08:34, Greg KH a écrit :
> On Tue, Jun 14, 2022 at 06:09:35AM +0000, Wenhu Wang wrote:
>>>
>>> Odd indentation, did you use checkpatch.pl on your patch?
>>>
>>
>> Actually, I checked with the scripts, and there was no warning here.
>> I also checked in text editors and vim, if I translate tab with 4 spaces,
>> the "vma/mem" areas in the 5 lines were aligned.
> 
> Tabs in Linux are always 8 spaces wide.
> 

See 
https://docs.kernel.org/process/coding-style.html?highlight=coding+style#indentation

Tabs are 8 characters, and thus indentations are also 8 characters. 
There are heretic movements that try to make indentations 4 (or even 2!) 
characters deep, and that is akin to trying to define the value of PI to 
be 3.

Christophe


More information about the Linuxppc-dev mailing list