[PATCH 2/3] powerpc/platforms/83xx/suspend: Prevent unloading the driver
Scott Wood
oss at buserror.net
Sat Jul 16 04:41:12 AEST 2022
On Thu, 2022-07-07 at 08:14 +0200, Uwe Kleine-König wrote:
> Returning an error in .remove() doesn't prevent a driver from being
> unloaded. On unbind this only results in an error message, but the
> device is remove anyhow.
>
> I guess the author's idea of just returning -EPERM in .remove() was to
> prevent unbinding a device. To achieve that set the suppress_bind_attrs
> driver property and drop the useless .remove callback.
I don't remember if I thought it would prevent removal, or if it was just the
only thing I could do to signal that removing it would be a bad idea (albeit
of relatively little consequence since it can't be built as a module).
suppress_bind_attrs didn't exist back then. :-)
In any case,
Acked-by: Scott Wood <oss at buserror.net>
-Scott
More information about the Linuxppc-dev
mailing list