oob read in do_adb_query function

sohu0106 sohu0106 at 126.com
Wed Jul 13 11:54:48 AEST 2022




In do_adb_query function of drivers/macintosh/adb.c, req->data is copy form userland. the  parameter "req->data[2]" is Missing check, the array size of adb_handler[] is 16, so "adb_handler[req->data[2]].original_address" and "adb_handler[req->data[2]].handler_id" will lead to oob read.
 


diff --git a/adb.c b/adb.c_patch
index 73b3961..8a5604b 100644
--- a/adb.c
+++ b/adb.c_patch
@@ -647,7 +647,7 @@ do_adb_query(struct adb_request *req)


        switch(req->data[1]) {
        case ADB_QUERY_GETDEVINFO:
-               if (req->nbytes < 3)
+               if (req->nbytes < 3 || req->data[2] > 16)
                        break;
                mutex_lock(&adb_handler_mutex);
                req->reply[0] = adb_handler[req-


More information about the Linuxppc-dev mailing list