[PATCH 2/2] cxl: Fix a memory leak in an error handling path

Christophe JAILLET christophe.jaillet at wanadoo.fr
Tue Jul 12 05:14:48 AEST 2022


A bitmap_zalloc() must be balanced by a corresponding bitmap_free() in the
error handling path of afu_allocate_irqs().

Signed-off-by: Christophe JAILLET <christophe.jaillet at wanadoo.fr>
---
The error handling path should be done in the reversed order but it should
work as-is.
---
 drivers/misc/cxl/irq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/misc/cxl/irq.c b/drivers/misc/cxl/irq.c
index 0ce91d99aead..b730e022a48e 100644
--- a/drivers/misc/cxl/irq.c
+++ b/drivers/misc/cxl/irq.c
@@ -349,6 +349,7 @@ int afu_allocate_irqs(struct cxl_context *ctx, u32 count)
 
 out:
 	cxl_ops->release_irq_ranges(&ctx->irqs, ctx->afu->adapter);
+	bitmap_free(ctx->irq_bitmap);
 	afu_irq_name_free(ctx);
 	return -ENOMEM;
 }
-- 
2.34.1



More information about the Linuxppc-dev mailing list