[PATCH 6/6] i2c: Make remove callback return void

Peter Rosin peda at axentia.se
Sat Jul 2 04:18:26 AEST 2022


2022-06-28 at 16:03, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <uwe at kleine-koenig.org>
> 
> The value returned by an i2c driver's remove function is mostly ignored.
> (Only an error message is printed if the value is non-zero that the
> error is ignored.)
> 
> So change the prototype of the remove function to return no value. This
> way driver authors are not tempted to assume that passing an error to
> the upper layer is a good idea. All drivers are adapted accordingly.
> There is no intended change of behaviour, all callbacks were prepared to
> return 0 before.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

For drivers I'm involved in, namely:

>  drivers/i2c/muxes/i2c-mux-ltc4306.c                       | 4 +---
>  drivers/i2c/muxes/i2c-mux-pca9541.c                       | 3 +--
>  drivers/i2c/muxes/i2c-mux-pca954x.c                       | 3 +--
>  sound/soc/codecs/max9860.c                                | 3 +--

Acked-by: Peter Rosin <peda at axentia.se>

Cheers,
Peter


More information about the Linuxppc-dev mailing list