[PATCH v2 4/4] KVM: PPC: Decrement module refcount if init_vm fails
Fabiano Rosas
farosas at linux.ibm.com
Wed Jan 26 02:08:33 AEDT 2022
Nicholas Piggin <npiggin at gmail.com> writes:
> Excerpts from Fabiano Rosas's message of January 25, 2022 8:08 am:
>> We increment the reference count for KVM-HV/PR before the call to
>> kvmppc_core_init_vm. If that function fails we need to decrement the
>> refcount.
>>
>> Signed-off-by: Fabiano Rosas <farosas at linux.ibm.com>
>> ---
>> Caught this while testing Nick's LPID patches by looking at
>> /sys/module/kvm_hv/refcnt
>
> Nice catch. Is this the only change in the series?
Yes.
> You can just use kvm_ops->owner like try_module_get() does I think? Also
> try_module_get works on a NULL module same as module_put by the looks,
> so you could adjust that in this patch to remove the NULL check so it
> is consistent with the put.
Sure, I'll send a v3.
More information about the Linuxppc-dev
mailing list