[PATCH] powerpc/audit: Fix syscall_get_arch()

Christophe Leroy christophe.leroy at csgroup.eu
Fri Jan 14 05:07:23 AEDT 2022


Commit 770cec16cdc9 ("powerpc/audit: Simplify syscall_get_arch()")
replaced test_tsk_thread_flag(task, TIF_32BIT)) by is_32bit_task().

But is_32bit_task() applies on current task while be want the test
done on task 'task'

So re-use test_tsk_thread_flag() instead.

Reported-by: Dmitry V. Levin <ldv at altlinux.org>
Fixes: 770cec16cdc9 ("powerpc/audit: Simplify syscall_get_arch()")
Cc: stable at vger.kernel.org
Signed-off-by: Christophe Leroy <christophe.leroy at csgroup.eu>
---
 arch/powerpc/include/asm/syscall.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/include/asm/syscall.h b/arch/powerpc/include/asm/syscall.h
index 52d05b465e3e..32f76833b736 100644
--- a/arch/powerpc/include/asm/syscall.h
+++ b/arch/powerpc/include/asm/syscall.h
@@ -105,7 +105,9 @@ static inline void syscall_get_arguments(struct task_struct *task,
 
 static inline int syscall_get_arch(struct task_struct *task)
 {
-	if (is_32bit_task())
+	if (IS_ENABLED(CONFIG_PPC32))
+		return AUDIT_ARCH_PPC;
+	else if (IS_ENABLED(CONFIG_COMPAT) && test_tsk_thread_flag(task, TIF_32BIT))
 		return AUDIT_ARCH_PPC;
 	else if (IS_ENABLED(CONFIG_CPU_LITTLE_ENDIAN))
 		return AUDIT_ARCH_PPC64LE;
-- 
2.33.1


More information about the Linuxppc-dev mailing list