[PATCH net v3] net: Force inlining of checksum functions in net/checksum.h

David Laight David.Laight at ACULAB.COM
Fri Feb 18 03:49:49 AEDT 2022


From: Masahiro Yamada
> Sent: 17 February 2022 16:17
...
> No.  Not that one.
> 
> The commit you presumably want to revert is:
> 
> a771f2b82aa2 ("[PATCH] Add a section about inlining to
> Documentation/CodingStyle")
> 
> This is now referred to as "__always_inline disease", though.

That description is largely fine.

Inappropriate 'inline' ought to be removed.
Then 'inline' means - 'really do inline this'.

Anyone remember massive 100+ line #defines being
used to get code inlined 'to make it faster'.
Sometimes being expanded several times in succession.
May have helped a 68020, but likely to be a loss on
modern cpu with large I-cache and slow memory.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)


More information about the Linuxppc-dev mailing list