[PATCH] net-wan: Add check for NULL for utdm in ucc_hdlc_probe
Ekaterina Esina
eesina at astralinux.ru
Sat Dec 24 01:32:25 AEDT 2022
If uhdlc_priv_tsa != 1 then utdm is not initialized.
And if ret != NULL then goto undo_uhdlc_init, where utdm is dereferenced.
Same if dev == NULL.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Ekaterina Esina <eesina at astralinux.ru>
---
drivers/net/wan/fsl_ucc_hdlc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
index 22edea6ca4b8..2ddb0f71e648 100644
--- a/drivers/net/wan/fsl_ucc_hdlc.c
+++ b/drivers/net/wan/fsl_ucc_hdlc.c
@@ -1243,7 +1243,9 @@ static int ucc_hdlc_probe(struct platform_device *pdev)
free_dev:
free_netdev(dev);
undo_uhdlc_init:
- iounmap(utdm->siram);
+ if (utdm != NULL) {
+ iounmap(utdm->siram);
+ }
unmap_si_regs:
iounmap(utdm->si_regs);
free_utdm:
--
2.30.2
More information about the Linuxppc-dev
mailing list