[PATCH v2 1/3] dt-bindings: reset: syscon-reboot: Add priority property
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Wed Aug 31 17:52:38 AEST 2022
On 31/08/2022 10:36, Pali Rohár wrote:
> On Wednesday 31 August 2022 10:31:22 Krzysztof Kozlowski wrote:
>> On 31/08/2022 02:00, Pali Rohár wrote:
>>> This new optional priority property allows to specify custom priority level
>>> of reset device. Default level was always 192.
>>
>> You still did not explain why do we need this. You only explained what
>> you did here, which is obvious and visible from the diff. What you
>> should explain is why you are doing it, what problem you are solving.
>>
>> Best regards,
>> Krzysztof
>
> Look at patch 3/3, thanks.
This commit should explain it why you add new property. Some other
commits going via different trees/branches and ending up in entirely
different time/place in history do not really count.
Best regards,
Krzysztof
More information about the Linuxppc-dev
mailing list