Fwd: [PATCH -next] objtool: use arch_jump_destination in read_intra_function_calls

Chen Zhongjin chenzhongjin at huawei.com
Mon Aug 22 12:42:11 AEST 2022


Sorry that forgot to CC ppc.

Maybe this is related to your intra-function call warnings problem?
Just a guess.

-------- Forwarded Message --------
Subject: 	[PATCH -next] objtool: use arch_jump_destination in 
read_intra_function_calls
Date: 	Thu, 18 Aug 2022 09:45:53 +0800
From: 	Chen Zhongjin <chenzhongjin at huawei.com>
To: 	linux-kernel at vger.kernel.org
CC: 	jpoimboe at kernel.org, peterz at infradead.org, chenzhongjin at huawei.com



arch_jump_destination() is used instead of offset + len + immediate
for jump destination.
But in read_intra_function_calls it didn't get changed.
It can make trouble for other arches development such as arm or ppc.
Fix it.

Signed-off-by: Chen Zhongjin <chenzhongjin at huawei.com>
---
tools/objtool/check.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 0cec74da7ffe..b012d987a658 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -2233,7 +2233,7 @@ static int read_intra_function_calls(struct 
objtool_file *file)
*/
insn->type = INSN_JUMP_UNCONDITIONAL;
- dest_off = insn->offset + insn->len + insn->immediate;
+ dest_off = arch_jump_destination(insn);
insn->jump_dest = find_insn(file, insn->sec, dest_off);
if (!insn->jump_dest) {
WARN_FUNC("can't find call dest at %s+0x%lx",

-- 
2.17.1




More information about the Linuxppc-dev mailing list