[PATCH] selftests/powerpc: Don't run spectre_v2 test by default
Russell Currey
ruscur at russell.cc
Fri Aug 5 11:48:07 AEST 2022
The spectre_v2 selftest has issues that I'm unsure of how to resolve.
It uses context to determine intended behaviour, but that context is
unreliable - as an example, when running as a KVM guest, qemu can
deliberately misreport mitigation status for compatibility purposes.
As a result, the selftest is unreliable as a pass/fail test without
the test runner knowing what they expect its behaviour to be. I don't
think the selftest is useless so we should keep it around, but we
shouldn't have run_tests run it by default.
Suggested-by: Eirik Fuller <efuller at redhat.com>
Signed-off-by: Russell Currey <ruscur at russell.cc>
---
tools/testing/selftests/powerpc/security/Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/powerpc/security/Makefile b/tools/testing/selftests/powerpc/security/Makefile
index 7488315fd847..c954d79aeb80 100644
--- a/tools/testing/selftests/powerpc/security/Makefile
+++ b/tools/testing/selftests/powerpc/security/Makefile
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: GPL-2.0+
-TEST_GEN_PROGS := rfi_flush entry_flush uaccess_flush spectre_v2
+TEST_GEN_PROGS := rfi_flush entry_flush uaccess_flush
+TEST_GEN_PROGS_EXTENDED := spectre_v2
TEST_PROGS := mitigation-patching.sh
top_srcdir = ../../../../..
@@ -10,6 +11,7 @@ CFLAGS += -I../../../../../usr/include
include ../../lib.mk
$(TEST_GEN_PROGS): ../harness.c ../utils.c
+$(TEST_GEN_PROGS_EXTENDED): ../harness.c ../utils.c
$(OUTPUT)/spectre_v2: CFLAGS += -m64
$(OUTPUT)/spectre_v2: ../pmu/event.c branch_loops.S
--
2.37.1
More information about the Linuxppc-dev
mailing list