[PATCH net-next 13/14] eth: spider: remove a copy of the NAPI_POLL_WEIGHT define

Geoff Levand geoff at infradead.org
Thu Apr 28 07:56:46 AEST 2022


Hi Jakub,

On 4/27/22 08:41, Jakub Kicinski wrote:
> Defining local versions of NAPI_POLL_WEIGHT with the same
> values in the drivers just makes refactoring harder.

> --- a/drivers/net/ethernet/toshiba/spider_net.c
> +++ b/drivers/net/ethernet/toshiba/spider_net.c
>  
>  	netif_napi_add(netdev, &card->napi,
> -		       spider_net_poll, SPIDER_NET_NAPI_WEIGHT);
> +		       spider_net_poll, NAPI_POLL_WEIGHT);

This seems fine. Both SPIDER_NET_NAPI_WEIGHT and NAPI_POLL_WEIGHT
are defined as 64.  Thanks for your contribution.

Acked-by: Geoff Levand <geoff at infradead.org>


More information about the Linuxppc-dev mailing list