[PATCH net-next v2] net: ethernet: Prepare cleanup of powerpc's asm/prom.h
Paolo Abeni
pabeni at redhat.com
Tue Apr 19 17:22:21 AEST 2022
Hello,
Sorry for the late reply.
On Fri, 2022-04-15 at 10:39 +0200, Christophe Leroy wrote:
> powerpc's asm/prom.h brings some headers that it doesn't
> need itself.
It's probably my fault, but I really can't parse the above. Could you
please re-phrase?
>
> In order to clean it up in a further step, first clean all
> files that include asm/prom.h
>
> Some files don't need asm/prom.h at all. For those ones,
> just remove inclusion of asm/prom.h
>
> Some files don't need any of the items provided by asm/prom.h,
> but need some of the headers included by asm/prom.h. For those
> ones, add the needed headers that are brought by asm/prom.h at
> the moment, then remove asm/prom.h
Do you mean a follow-up patch is needed to drop the asm/prom.h include
from such files, even if that include could be dropped now without any
fourther change?
If so, I suggest v3 should additionally drop the asm/prom.h include
where possible.
Thanks!
Paolo
More information about the Linuxppc-dev
mailing list