[PATCH v2 5/9] cxl/pci: Make more use of cxl_register_map

Dan Williams dan.j.williams at intel.com
Wed Sep 29 03:41:24 AEST 2021


On Thu, Sep 23, 2021 at 10:27 AM Ben Widawsky <ben.widawsky at intel.com> wrote:
>
> The structure exists to pass around information about register mapping.
> Using it more extensively cleans up many existing functions.

I would have liked to have seen "add @base to cxl_register_map" and
"use @map for @bar and @offset arguments" somewhere in this changelog
to set expectations for what changes are included. That would have
also highlighted that adding a @base to cxl_register_map deserves its
own patch vs the conversion of @bar and @offset to instead use
@map->bar and @map->offset. Can you resend with that split and those
mentions?


More information about the Linuxppc-dev mailing list