[PATCH v2 9/9] iommu/vt-d: Use pci core's DVSEC functionality

Christoph Hellwig hch at infradead.org
Fri Sep 24 16:42:27 AEST 2021


On Thu, Sep 23, 2021 at 10:26:47AM -0700, Ben Widawsky wrote:
>   */
>  static int siov_find_pci_dvsec(struct pci_dev *pdev)
>  {
> +	return pci_find_dvsec_capability(pdev, PCI_VENDOR_ID_INTEL, 5);
>  }

I hink the siov_find_pci_dvsec helper is pretty pointless now and can be
folded into its only caller.  And independent of that: this capability
really needs a symbolic name.  Especially for a vendor like Intel that
might have a few there should be a list of them somewhere.



More information about the Linuxppc-dev mailing list