[PATCH 3/3] powerpc/pseries/cpuhp: delete add/remove_by_count code
kernel test robot
lkp at intel.com
Tue Sep 21 07:50:55 AEST 2021
Hi Nathan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on linus/master v5.15-rc2 next-20210920]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Nathan-Lynch/CPU-DLPAR-hotplug-for-v5-16/20210920-215907
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/72ea4c8a5398a4a72da34051a66f260ab0154f57
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nathan-Lynch/CPU-DLPAR-hotplug-for-v5-16/20210920-215907
git checkout 72ea4c8a5398a4a72da34051a66f260ab0154f57
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>
All errors (new ones prefixed by >>):
arch/powerpc/platforms/pseries/hotplug-cpu.c: In function 'dlpar_cpu':
>> arch/powerpc/platforms/pseries/hotplug-cpu.c:746:13: error: variable 'count' set but not used [-Werror=unused-but-set-variable]
746 | u32 count, drc_index;
| ^~~~~
cc1: all warnings being treated as errors
vim +/count +746 arch/powerpc/platforms/pseries/hotplug-cpu.c
ac71380071d19d Nathan Fontenot 2015-12-16 743
ac71380071d19d Nathan Fontenot 2015-12-16 744 int dlpar_cpu(struct pseries_hp_errorlog *hp_elog)
ac71380071d19d Nathan Fontenot 2015-12-16 745 {
ac71380071d19d Nathan Fontenot 2015-12-16 @746 u32 count, drc_index;
ac71380071d19d Nathan Fontenot 2015-12-16 747 int rc;
ac71380071d19d Nathan Fontenot 2015-12-16 748
ac71380071d19d Nathan Fontenot 2015-12-16 749 count = hp_elog->_drc_u.drc_count;
ac71380071d19d Nathan Fontenot 2015-12-16 750 drc_index = hp_elog->_drc_u.drc_index;
ac71380071d19d Nathan Fontenot 2015-12-16 751
ac71380071d19d Nathan Fontenot 2015-12-16 752 lock_device_hotplug();
ac71380071d19d Nathan Fontenot 2015-12-16 753
ac71380071d19d Nathan Fontenot 2015-12-16 754 switch (hp_elog->action) {
ac71380071d19d Nathan Fontenot 2015-12-16 755 case PSERIES_HP_ELOG_ACTION_REMOVE:
72ea4c8a5398a4 Nathan Lynch 2021-09-20 756 if (hp_elog->id_type == PSERIES_HP_ELOG_ID_DRC_INDEX) {
ac71380071d19d Nathan Fontenot 2015-12-16 757 rc = dlpar_cpu_remove_by_index(drc_index);
29c9a2699e71a7 Daniel Henrique Barboza 2021-04-16 758 /*
29c9a2699e71a7 Daniel Henrique Barboza 2021-04-16 759 * Setting the isolation state of an UNISOLATED/CONFIGURED
29c9a2699e71a7 Daniel Henrique Barboza 2021-04-16 760 * device to UNISOLATE is a no-op, but the hypervisor can
29c9a2699e71a7 Daniel Henrique Barboza 2021-04-16 761 * use it as a hint that the CPU removal failed.
29c9a2699e71a7 Daniel Henrique Barboza 2021-04-16 762 */
29c9a2699e71a7 Daniel Henrique Barboza 2021-04-16 763 if (rc)
29c9a2699e71a7 Daniel Henrique Barboza 2021-04-16 764 dlpar_unisolate_drc(drc_index);
29c9a2699e71a7 Daniel Henrique Barboza 2021-04-16 765 }
ac71380071d19d Nathan Fontenot 2015-12-16 766 else
ac71380071d19d Nathan Fontenot 2015-12-16 767 rc = -EINVAL;
ac71380071d19d Nathan Fontenot 2015-12-16 768 break;
90edf184b9b727 Nathan Fontenot 2015-12-16 769 case PSERIES_HP_ELOG_ACTION_ADD:
72ea4c8a5398a4 Nathan Lynch 2021-09-20 770 if (hp_elog->id_type == PSERIES_HP_ELOG_ID_DRC_INDEX)
90edf184b9b727 Nathan Fontenot 2015-12-16 771 rc = dlpar_cpu_add(drc_index);
90edf184b9b727 Nathan Fontenot 2015-12-16 772 else
90edf184b9b727 Nathan Fontenot 2015-12-16 773 rc = -EINVAL;
90edf184b9b727 Nathan Fontenot 2015-12-16 774 break;
ac71380071d19d Nathan Fontenot 2015-12-16 775 default:
ac71380071d19d Nathan Fontenot 2015-12-16 776 pr_err("Invalid action (%d) specified\n", hp_elog->action);
ac71380071d19d Nathan Fontenot 2015-12-16 777 rc = -EINVAL;
ac71380071d19d Nathan Fontenot 2015-12-16 778 break;
ac71380071d19d Nathan Fontenot 2015-12-16 779 }
ac71380071d19d Nathan Fontenot 2015-12-16 780
ac71380071d19d Nathan Fontenot 2015-12-16 781 unlock_device_hotplug();
ac71380071d19d Nathan Fontenot 2015-12-16 782 return rc;
ac71380071d19d Nathan Fontenot 2015-12-16 783 }
ac71380071d19d Nathan Fontenot 2015-12-16 784
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 74041 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20210921/d7dd5a05/attachment-0001.gz>
More information about the Linuxppc-dev
mailing list