[PATCH 3/9] powerpc/bpf: Remove unused SEEN_STACK
Christophe Leroy
christophe.leroy at csgroup.eu
Tue Oct 5 16:50:16 AEDT 2021
Le 04/10/2021 à 20:11, Naveen N. Rao a écrit :
> Christophe Leroy wrote:
>>
>>
>> Le 01/10/2021 à 23:14, Naveen N. Rao a écrit :
>>> From: Ravi Bangoria <ravi.bangoria at linux.ibm.com>
>>>
>>> SEEN_STACK is unused on PowerPC. Remove it. Also, have
>>> SEEN_TAILCALL use 0x40000000.
>>
>> Why change SEEN_TAILCALL ? Would it be a problem to leave it as is ?
>>
>>>
>>> Signed-off-by: Ravi Bangoria <ravi.bangoria at linux.ibm.com>
>>> Reviewed-by: Christophe Leroy <christophe.leroy at csgroup.eu>
>
> I prefer the bit usage to be contiguous. Changing SEEN_TAILCALL isn't a
> problem either.
>
Well you are adding SEEN_BIG_PROG in following patch so it would still
be contiguous at the end.
I don't really mind but I thought it would be less churn to just leave
SEEN_TAILCALL as is and re-use 0x40000000 for SEEN_BIG_PROG.
Anyway
Reviewed-by: Christophe Leroy <christophe.leroy at csgroup.eu>
More information about the Linuxppc-dev
mailing list