[PATCH] powerpc/pseries/vas: Don't print an error when VAS is unavailable

[Cédric Le Goater]

On 11/26/21 06:21, Nicholas Piggin wrote:
> KVM does not support VAS so guests always print a useless error on boot
> 
>      vas: HCALL(398) error -2, query_type 0, result buffer 0x57f2000
> 
> Change this to only print the message if the error is not H_FUNCTION.


Just being curious, why is it even called since "ibm,compression" should
not be exposed in the DT ?

C.

> 
> Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
> ---
>   arch/powerpc/platforms/pseries/vas.c | 11 +++++++++--
>   1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/pseries/vas.c b/arch/powerpc/platforms/pseries/vas.c
> index b043e3936d21..734523e2272f 100644
> --- a/arch/powerpc/platforms/pseries/vas.c
> +++ b/arch/powerpc/platforms/pseries/vas.c
> @@ -151,8 +151,15 @@ int h_query_vas_capabilities(const u64 hcall, u8 query_type, u64 result)
>   	if (rc == H_SUCCESS)
>   		return 0;
>   
> -	pr_err("HCALL(%llx) error %ld, query_type %u, result buffer 0x%llx\n",
> -			hcall, rc, query_type, result);
> +	/* H_FUNCTION means HV does not support VAS so don't print an error */
> +	if (rc != H_FUNCTION) {
> +		pr_err("%s error %ld, query_type %u, result buffer 0x%llx\n",
> +			(hcall == H_QUERY_VAS_CAPABILITIES) ?
> +				"H_QUERY_VAS_CAPABILITIES" :
> +				"H_QUERY_NX_CAPABILITIES",
> +			rc, query_type, result);
> +	}
> +
>   	return -EIO;
>   }
>   EXPORT_SYMBOL_GPL(h_query_vas_capabilities);
>