[PATCH] powerpc/prom_init: fix the improper check of prom_getprop
Peiwei Hu
jlu.hpw at foxmail.com
Fri Nov 19 20:12:18 AEDT 2021
prom_getprop() can return PROM_ERROR. Binary operator can not identify it.
Signed-off-by: Peiwei Hu <jlu.hpw at foxmail.com>
---
arch/powerpc/kernel/prom_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
index 18b04b08b983..f845065c860e 100644
--- a/arch/powerpc/kernel/prom_init.c
+++ b/arch/powerpc/kernel/prom_init.c
@@ -2991,7 +2991,7 @@ static void __init fixup_device_tree_efika_add_phy(void)
/* Check if the phy-handle property exists - bail if it does */
rv = prom_getprop(node, "phy-handle", prop, sizeof(prop));
- if (!rv)
+ if (rv <= 0)
return;
/*
--
2.25.1
More information about the Linuxppc-dev
mailing list