[PATCH v2 5/5] powerpc/watchdog: Remove backtrace print from unstuck message

Nicholas Piggin npiggin at gmail.com
Fri Nov 5 12:28:33 AEDT 2021


Excerpts from Laurent Dufour's message of November 5, 2021 2:48 am:
> Le 04/11/2021 à 17:10, Nicholas Piggin a écrit :
>> The watchdog unstuck message can't be serialised with other watchdog
>> messages because that might prevent watchdog reporting. This removes
>> the big backtrace from the unstuck message, which can get mixed with
>> other messages and confuse logs, and just prints a single line.
> 
> I'm not sure that's a good idea to remove the registers and backtrace here.
> I agree that this output may interleaved (and usually it does), but it is also 
> providing some good information about the culprit block of code. Usually, it's 
> pointing the IRQ release code, and so the IRQ blocking one which are really useful.

Okay, I was thinking that be inferred from the context usually, but 
sometimes it's not that easy which I guess is why I added it in the
first place.

> I don't have a good way to prevent trace interleaving here, but I think 
> interleaved traces are better here than nothing.

Okay we can leave this patch off.

Thanks,
Nick


More information about the Linuxppc-dev mailing list