[PATCH] powerpc/udbg_hvc: retry putc on -EAGAIN

Michael Ellerman mpe at ellerman.id.au
Sun May 23 20:51:09 AEST 2021

Greg KH <gregkh at linuxfoundation.org> writes:
> On Fri, May 14, 2021 at 04:44:22PM -0500, Nathan Lynch wrote:
>> hvterm_raw_put_chars() calls hvc_put_chars(), which may return -EAGAIN
>> when the underlying hcall returns a "busy" status, but udbg_hvc_putc()
>> doesn't handle this. When using xmon on a PowerVM guest, this can
>> result in incomplete or garbled output when printing relatively large
>> amounts of data quickly, such as when dumping the kernel log buffer.
>> Call again on -EAGAIN.
>> Signed-off-by: Nathan Lynch <nathanl at linux.ibm.com>
>> ---
>>  drivers/tty/hvc/hvc_vio.c | 2 +-
> Subject line does not match up with this file name.
> Don't you want "tty" and "hvc" in there somewhere?

It's a powerpc only driver, but I guess the subject should still be
"tty: hvc: ..." to match convention.

I was planning to take this via the powerpc tree, but I can drop it if
you'd rather take it.


More information about the Linuxppc-dev mailing list