[PATCH v5 5/9] powerpc/mm/book3s64: Update tlb flush routines to take a page walk cache flush argument

Michael Ellerman mpe at ellerman.id.au
Thu May 20 21:38:02 AEST 2021

Guenter Roeck <linux at roeck-us.net> writes:
> On 5/18/21 5:26 PM, Michael Ellerman wrote:
> [ ... ]
>>>> That was the generic header change in the patch. I was commenting about the
>>>> ppc64 specific change causing build failures.
>>> Ah, sorry. I wasn't aware that the following is valid C code
>>> void f1()
>>> {
>>>       return f2();
>>>       ^^^^^^
>>> }
>>> as long as f2() is void as well. Confusing, but we live and learn.
>> It might be valid, but it's still bad IMHO.
>> It's confusing to readers, and serves no useful purpose.
> Agreed, but it is surprisingly wide-spread. Try to run the coccinelle
> script below, just for fun. The script doesn't even catch instances
> in include files, yet there are more than 450 hits.

Yikes, that is a lot.

I guess they're pretty harmless, but would be nice to clean them up

Why doesn't the script work for instances in headers?


More information about the Linuxppc-dev mailing list